Re: [PATCH] virDomainInterfaceStats: Accept MAC addresses properly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/13/2017 05:44 PM, John Ferlan wrote:
> 
> 
> On 10/13/2017 07:32 PM, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1497396
>>
>> In 0d3d020ba6c4f I've added capability to accept MAC addresses
>> for the API too. However, the implementation was faulty. It needs
>> to lookup the corresponding interface in the domain definition
>> and pass the ifname instead of MAC address.
>>
>> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
>> ---
>>  src/libxl/libxl_driver.c   | 2 +-
>>  src/lxc/lxc_driver.c       | 2 +-
>>  src/openvz/openvz_driver.c | 2 +-
>>  src/qemu/qemu_driver.c     | 4 ++--
>>  4 files changed, 5 insertions(+), 5 deletions(-)
>>
> 
> face-palm - so much for my assumptions

Yeah, I facepalmed too when noticing this. Fortunately, the patch is
pretty simple.

> 
> Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>
> 

Pushed. Thanks.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux