Re: [PATCH 4/4] virDomainNetFind: Report error if no device found

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/05/2017 10:18 AM, Michal Privoznik wrote:
> Every caller reports the error themselves. Might as well move it
> into the function and thus unify it.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c     | 18 ++++++++++--------
>  src/libxl/libxl_driver.c   |  5 +----
>  src/lxc/lxc_driver.c       |  5 +----
>  src/openvz/openvz_driver.c |  5 +----
>  src/qemu/qemu_driver.c     | 21 ++++-----------------
>  src/test/test_driver.c     |  5 +----
>  src/xen/xen_driver.c       |  5 +----
>  7 files changed, 19 insertions(+), 45 deletions(-)
> 

As noted eariler, I think this patch should go earlier thus affecting
less files to change in the long run.

With the adjustment,

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux