Re: [PATCH 17/23] cputest: Add query-cpu-definitions reply for Core-i5-2540M

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/04/2017 10:58 AM, Jiri Denemark wrote:
> The unavailable features do not make any difference in this case,
> because this is a SandyBridge CPU which has an empty list of unavailable
> features.
> 
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
>  tests/cputest.c                                   |   2 +-
>  tests/cputestdata/x86_64-cpuid-Core-i5-2540M.json | 362 ++++++++++++++++++++++
>  2 files changed, 363 insertions(+), 1 deletion(-)
> 

[...]

> diff --git a/tests/cputestdata/x86_64-cpuid-Core-i5-2540M.json b/tests/cputestdata/x86_64-cpuid-Core-i5-2540M.json
> index d813326f6f..a8ed64ed63 100644
> --- a/tests/cputestdata/x86_64-cpuid-Core-i5-2540M.json
> +++ b/tests/cputestdata/x86_64-cpuid-Core-i5-2540M.json

[...]

> +    {
> +      "typename": "Skylake-Client-x86_64-cpu",
> +      "unavailable-features": [
> +        "fma",
> +        "movbe",
> +        "f16c",
> +        "rdrand",
> +        "fsgsbase",
> +        "bmi1",
> +        "hle",
> +        "avx2",
> +        "smep",
> +        "bmi2",
> +        "erms",
> +        "invpcid",
> +        "rtm",
> +        "mpx",
> +        "rdseed",
> +        "adx",
> +        "smap",
> +        "abm",
> +        "3dnowprefetch",
> +        "xsavec",
> +        "xgetbv1",
> +        "mpx",
> +        "mpx"

Is this a typo or bad cut-n-paste - "mpx" three times in the list?

> +      ],
> +      "migration-safe": true,
> +      "static": false,
> +      "name": "Skylake-Client"
> +    },

Others seemed fine... Tried looking through QEMU sources - got lost
quickly and gave up.

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux