On 10/12/2017 02:07 PM, Peter Krempa wrote:
> chain->path may be NULL e.g. for NDB drives, so the check needs to avoid
s/NDB/NBD/ ?
> dereferencing the path in such case
> ---
> src/util/virstoragefile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>
>
> diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
> index 9568a5068..818a679de 100644
> --- a/src/util/virstoragefile.c
> +++ b/src/util/virstoragefile.c
> @@ -1610,7 +1610,7 @@ virStorageFileChainLookup(virStorageSourcePtr chain,
> break;
> } else {
> if (STREQ_NULLABLE(name, chain->relPath) ||
> - STREQ(name, chain->path))
> + STREQ_NULLABLE(name, chain->path))
> break;
>
> if (nameIsFile && virStorageSourceIsLocalStorage(chain)) {
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
