Re: [PATCH 2/9] conf: Make backing store index optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/12/2017 02:07 PM, Peter Krempa wrote:
> Index will remain an internal property even if we allow backing store
> parsing from the XML, so we need to allow backing store without it in
> the schema.
> ---
>  docs/schemas/domaincommon.rng | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 4dbda6932..a3aa6eba2 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -1415,9 +1415,11 @@
> 
>    <define name="diskBackingStore">
>      <element name="backingStore">
> +     <optional>
>        <attribute name="index">
>          <ref name="positiveInteger"/>
>        </attribute>
> +    </optional>
>        <interleave>

Spacing looks funky (not the usual 2-space indentation, including
reindenting the <attribute> tag).  The parser doesn't care, but it might
be nice to touch up on commit.

Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux