Re: [PATCH 3/3] nodedev: Introduce virNodeDeviceObjListForEachCb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 12, 2017 at 03:46:25PM +0200, Erik Skultety wrote:
> On Tue, Oct 10, 2017 at 09:54:28AM -0400, John Ferlan wrote:
> > Rather than separate functions for NumOfDevices, GetNames, and
> > ListExport - let's converge the code into one handler.
> >
> > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> > ---
>
> NACK, for the very same reasons stated in [1], IOW we really should not make
> this a busybox. But unlike [1], I'm not entirely sure what a nice cleanup would
> look like (and it sure needs some).

A link would be actually nice too.

[1] https://www.redhat.com/archives/libvir-list/2017-October/msg00464.html

Erik

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux