Re: [PATCH] util: Resolve resource leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 11, 2017 at 05:03:05PM -0400, John Ferlan wrote:
> Need to free @groups in the parent on success similar to other
> APIs (virFile*) which use virGetGroupList and virFork.
>
> Reported by Coverity.
>
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/util/vircommand.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/util/vircommand.c b/src/util/vircommand.c
> index 41a61da49f..6cd76a560e 100644
> --- a/src/util/vircommand.c
> +++ b/src/util/vircommand.c
> @@ -606,6 +606,7 @@ virExec(virCommandPtr cmd)
>
>          cmd->pid = pid;
>
> +        VIR_FREE(groups);
>          VIR_FREE(binarystr);
>
>          return 0;

Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux