On 10/06/2017 08:23 AM, Michal Privoznik wrote:
>>> .spec is not in the repo, so it's never checked. And then, we perhaps
>>> want to check .spec.in? For instance for space at EOF.
>>
>> .spec is generated from .spec.in, so for a builddir==srcdir build,
>> syntax-check will find both; hence, IMHO both ought to be either
>> skipped or checked, but together.
>
> Is that right? I always thought that syntax-check runs only over the
> files that are in the git and not generated ones:
Many checks run only on checked-in files, but some checks also run on
in-tree files. It depends whether the check was written with
in_vc_files, in_files, or something else.
In fact, many builtin rules in maint.mk use:
in_vc_files='\.[chly]$$'
to limit to C-like files; I think part of the problem is that there are
syntax-check rules that forget to use this limiting filter, and end up
getting applied to too many files.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
