Re: [PATCH REPOST 5/6] test: Create local virStoragePoolObjPtr VolLookup APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/05/2017 10:23 PM, John Ferlan wrote:
> Rather than accessing privconn->pools.objs[i] in the for loop,
> let's use an @obj variable to make it easier to read the code.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/test/test_driver.c | 30 ++++++++++++++++--------------
>  1 file changed, 16 insertions(+), 14 deletions(-)
> 
> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> index a1a74b8bd1..e84acf3228 100644
> --- a/src/test/test_driver.c
> +++ b/src/test/test_driver.c
> @@ -4905,27 +4905,28 @@ testStorageVolLookupByKey(virConnectPtr conn,
>                            const char *key)
>  {
>      testDriverPtr privconn = conn->privateData;
> +    virStoragePoolObjPtr obj;

How about s/obj/poolObj/ or something so that one know just from looking
whether obj refers to pool or volume. But I don't care that much.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux