On Wed, Oct 04, 2017 at 10:55:58 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1475250 > > It's possible to define and start a pool with a '.' in the > name; however, when trying to add a volume to a domain using > the storage pool source with a '.' in the storage pool name, > the domain RNG validation fails because RNG uses 'genericName' > which does not allow a '.' in the name. > > Domain XML def parsing has a virXMLValidateAgainstSchema which > generates the error. The Storage Pool XML def parsing has no > call to virXMLValidateAgainstSchema. The only Storage Pool name > validation occurs in virStoragePoolDefParseXML to ensure the > name doesn't have a '/' in it and in storagePoolDefineXML to > call virXMLCheckIllegalChars using the same parameter "\n" as > qemuDomainDefineXMLFlags would check after the RNG check > could be succesful. > > In order to resolve this, create a poolName definition in > storagecommon.rng that will mimic the domain name regex that > disallows a newline character, but add the "/" in the exclude > list. Then modify the pool and volume source name definitions > to key off that poolName. > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > > v1: https://www.redhat.com/archives/libvir-list/2017-September/msg01037.html > > Change only to add '/' before the newline in poolName > > docs/schemas/domaincommon.rng | 2 +- > docs/schemas/storagecommon.rng | 8 ++++++++ > docs/schemas/storagepool.rng | 4 ++-- > 3 files changed, 11 insertions(+), 3 deletions(-) ACK
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
