Re: [PATCH 3/7] qemu: process: Pass flags to qemuProcessPrepareHost

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 04, 2017 at 11:59:07 -0400, John Ferlan wrote:
> 
> 
> On 10/04/2017 07:42 AM, Peter Krempa wrote:
> > Pass flags to the function rather than just whether we have incoming
> > migration. This also enforces correct startup policy for USB devices
> > when reverting from a snapshot.
> > ---
> >  src/qemu/qemu_migration.c | 2 +-
> >  src/qemu/qemu_process.c   | 8 ++++----
> >  src/qemu/qemu_process.h   | 2 +-
> >  3 files changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> > index 078da1dfd..dd60071bf 100644
> > --- a/src/qemu/qemu_migration.c
> > +++ b/src/qemu/qemu_migration.c
> > @@ -2687,7 +2687,7 @@ qemuMigrationPrepareAny(virQEMUDriverPtr driver,
> >      if (qemuProcessPrepareDomain(dconn, driver, vm, startFlags) < 0)
> >          goto stopjob;
> > 
> > -    if (qemuProcessPrepareHost(driver, vm, !!incoming) < 0)
> > +    if (qemuProcessPrepareHost(driver, vm, startFlags) < 0)
> 
> yah! - removing an essentially useless !!incoming since it couldn't be
> anything but true...

Well. Now it won't be anything but VIR_QEMU_PROCESS_START_AUTODESTROY

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux