On Wed, Oct 04, 2017 at 12:09:04 -0400, John Ferlan wrote:
>
>
> On 10/04/2017 07:42 AM, Peter Krempa wrote:
> > Checking of disk presence accesses storage on the host so it should be
> > done from the host setup function. Move the code to new function called
> > qemuProcessPrepareHostStorage and remove qemuDomainCheckDiskPresence.
> > ---
> > src/qemu/qemu_domain.c | 41 -----------------------------------------
> > src/qemu/qemu_process.c | 46 ++++++++++++++++++++++++++++++++++++++++++----
> > 2 files changed, 42 insertions(+), 45 deletions(-)
> >
>
> [...]
>
> >
> > +static int
> > +qemuProcessPrepareHostStorage(virQEMUDriverPtr driver,
> > + virDomainObjPtr vm,
> > + unsigned int flags)
> > +{
> > + size_t i;
> > + bool cold_boot = flags & VIR_QEMU_PROCESS_START_COLD;
> > +
>
> Consider my note from patch 5/7. Previously this loop essentially
> wasn't run for the pretend environment. Now it will be, although since
> @flags is passed it conceivably could be checked. My make check passes
> either way, so it may not matter, but figured to point it out for purely
> testing purposes it seems.
It won't. Previously it was called from the domain prepare function
which is called in qemuProcessCreatePretendCmd which is the only place
that sets VIR_QEMU_PROCESS_START_PRETEND.
By moving the code to the "host prepare" function we gain that by
default.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
