[...] > > I don't think this is right. Consider the following scenario. There are > two interfaces in a domain with $mac1, $pci1 and $mac2, $pci2. What > happens if user passes $mac1+$pci2 or vice versa? With my code, we error > out. With this suggestion we match device based on PCI address (even Fair point, I haven't considered this scenario, as I couldn't imagine someone hitting this corner case. Nevertheless, doesn't matter, mine assumption was wrong, thank you for pointing it out. Erik -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list