2009/7/27 Tom Hughes <tom@xxxxxxxxxx>: > On 27/07/09 06:17, Shahar Klein wrote: >> >> I'll try with 7.15 >> >> can I test with ESX4i? > > ESX4i doesn't seem to work yet - the API version has changed: > > error: internal error Expecting VI API version '2.5.0' or '2.5u2' but found > '4.0' The driver development was done based on ESX 3.5, I haven't checked yet what changed between VI API version 2.5 and 4.0, but that's already on the todo list. > Patching libvirt to allow the 4.0 API version allows me to connect and list > guests, but trying to dumpxml a guest definition fails: > > virsh # dumpxml alvis > error: memory conf:1: expecting a name What's the content of line number 1 of the alvis.vmx file? > Then again dumpxml fails for me with ESX3i as well, though with a different > error: > > virsh # dumpxml bsa > error: internal error Missing essential config entry 'scsi0.virtualDev' Oh, that's a bug in the VMX parsing code, I'll fix that. The VMX parsing hasn't get much testing with in-the-wild VMX files yet. It would be useful if you could send my some of your VMX files to build up a pool as input for automatic testing and to make the VMX parser more robust. You could apply this quick fix for testing: diff --git a/src/esx/esx_vmx.c b/src/esx/esx_vmx.c index 635a483..dddb7c4 100644 --- a/src/esx/esx_vmx.c +++ b/src/esx/esx_vmx.c @@ -822,7 +822,7 @@ esxVMX_ParseSCSIController(virConnectPtr conn, virConfPtr conf, int controller, } if (esxUtil_GetConfigString(conn, conf, virtualDev_name, - virtualDev, 0) < 0) { + virtualDev, 1) < 0) { goto failure; } Regards, Matthias -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list