Re: [PATCH] tests: Do not ignore mode parameter in mocked open()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 03, 2017 at 02:07:18PM +0200, Jiri Denemark wrote:
From: Luyao Huang <lhuang@xxxxxxxxxx>

This is normally not an issue since the tests which use mocked open() do
not create files. But once coverage build is enabled, gcov_open will use
O_CREATE and real_open will read random data rather than the actual mode
argument.

Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
---
tests/virfilewrapper.c | 13 ++++++++++++-
tests/virusbmock.c     | 15 ++++++++++++++-
2 files changed, 26 insertions(+), 2 deletions(-)


ACK, I guess you don't need this in the release, do you?

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux