Re: [libvirt] [PATCH] test: Implement BlockStats and InterfaceStats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Daniel Veillard wrote:
> On Fri, Jul 24, 2009 at 11:05:30AM -0400, Cole Robinson wrote:
>> We fake stats values based on the current time, similar to how it's done
>> for cpu time.
> 
>> +    if (gettimeofday(&tv, NULL) < 0) {
>> +        virReportSystemError(domain->conn, errno,
>> +                             "%s", _("getting time of day"));
>> +        goto error;
>> +    }
> 
>   can gettimeofday fail if the args are correct ? But that's fine :-)
> 
> With the second patch that looks fine.
> 
>   ACK
> 
> daniel
> 

I've pushed these patches now.

Thanks,
Cole

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]