Re: [PATCH v2 0/2] Clean up the nwfilter mess I created

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 29, 2017 at 04:02:48PM -0400, John Ferlan wrote:
v1: https://www.redhat.com/archives/libvir-list/2017-September/msg01072.html

Changes:

* Patch1: No change, ACK'd, but not safe to push yet either..

* Patch2: Rather than have virNWFilterIPAddrMapAddIPAddr consume
          the input @addr, let's make a copy of the input parameter
          and manage it within that code so that it wouldn't be
          consumed on virNWFilterHashTablePut failure after
          virNWFilterVarValueCreateSimple success.

John Ferlan (2):
 Revert "nwfilter: Fix possible segfault on sometimes consumed
   variable"
 nwfilter: Don't have virNWFilterIPAddrMapAddIPAddr consume input

src/conf/nwfilter_ipaddrmap.c     | 16 +++++++++-------
src/nwfilter/nwfilter_dhcpsnoop.c |  3 ---
2 files changed, 9 insertions(+), 10 deletions(-)

ACK series

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux