[PATCH 0/2] Clean up the nwfilter mess I created

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Silly me - touching the nwfilter code... Turns out the reverted patch
in 1/2 doesn't cover it as virNWFilterVarValueCreateSimple actually
steals @addr, so freeing it on successful return ends up being a very
bad thing as I found out with the nwfilter avocado-vt tests.

So revert that and just go with the only free on failure logic in patch2

John Ferlan (2):
  Revert "nwfilter: Fix possible segfault on sometimes consumed
    variable"
  nwfilter: Only free inetaddr on virNWFilterIPAddrMapAddIPAddr failure

 src/conf/nwfilter_ipaddrmap.c       | 9 +--------
 src/nwfilter/nwfilter_learnipaddr.c | 5 ++++-
 2 files changed, 5 insertions(+), 9 deletions(-)

-- 
2.13.5

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux