Re: [PATCH 1/2] conf: fix formatting of udp chardev attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 26, 2017 at 01:58:52PM +0200, Ján Tomko wrote:
It is possible (although possibly not very useful) to leave out
the service attribute when using <source mode='bind'/>

Fix the formatter bug introduced by commit 4a0da34 and format
the host when its present (checked for non-NULL inside
virBufferEscapeString) instead of basing it on the presence
of the service attribute.

https://bugzilla.redhat.com/show_bug.cgi?id=1455825
---
src/conf/domain_conf.c                              | 12 ++++--------
tests/genericxml2xmloutdata/generic-chardev-udp.xml |  2 +-
2 files changed, 5 insertions(+), 9 deletions(-)


NACK to this one,

I have already sent it separately:
https://www.redhat.com/archives/libvir-list/2017-September/msg00921.html

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux