Re: [PATCH python] Fix comparisons between signed & unsigned integers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 26, 2017 at 01:36:13PM +0200, Martin Kletzander wrote:
> On Tue, Sep 26, 2017 at 11:16:05AM +0100, Daniel P. Berrange wrote:
> > When python3 builds C modules, it adds the -Wsign-compare flag to GCC.
> > This creates lots of warnings where we compare a 'size_t' value against
> > an 'int' value due to signed/unsigned difference.  Change all the size_t
> > types to ssize_t to address this.
> > 
> > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> 
> Hm, I wanted this to be the case when we started to force using size_t for i,j,k
> variables, but looks like I was the only one who wanted ssize_t (plus we would
> be able to do that only in some places, so automatic enforcement without
> -Wsign-compare would not be easily possible)

In libvirt.git we disabled  -Wsign-compare, but in python the CFlags aren't
under our direct control - python distutils decides AFAICT.

> ACK



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux