On 08/24/2017 03:08 PM, John Ferlan wrote:
> Consider this round 1 of 2.... The next series will be 18 patches,
> but the majority of those deal with change every {pool|obj}->def->X
> to use the accessor virStoragePoolObjGetDef.
>
> v1: https://www.redhat.com/archives/libvir-list/2017-May/msg00218.html
>
> Probably not even worth looking at the v1, but this picks up where v1
> left off somewhere around patch 10, but adding smaller steps between
> patches.
>
>
> John Ferlan (12):
> storage: Create accessor API's for virStoragePoolObj
> storage: Introduce virStoragePoolObjNew
> storage: Fill in storage pool @active properly
> storage: Introduce storage volume add, delete, count APIs
> storage: Introduce APIs to search/scan storage pool volumes list
> storage: Use virStoragePoolObj{Get|Set}ConfigFile
> storage: Use virStoragePoolObjGetAutostartLink
> storage: Use virStoragePoolObj{Is|Set}Active
> storage: Use virStoragePoolObj{Is|Set}Autostart
> storage: Internally represent @autostart to bool
> storage: Use virStoragePoolObj{Get|Incr}Decr}Asyncjobs
> storage: Use virStoragePoolObjDefUseNewDef
>
> src/conf/virstorageobj.c | 211 +++++++++++++++++++++++++++++++--
> src/conf/virstorageobj.h | 84 ++++++++++++-
> src/libvirt_private.syms | 20 ++++
> src/storage/storage_backend_disk.c | 93 +++++++++------
> src/storage/storage_backend_gluster.c | 5 +-
> src/storage/storage_backend_logical.c | 4 +-
> src/storage/storage_backend_mpath.c | 3 +-
> src/storage/storage_backend_rbd.c | 4 +-
> src/storage/storage_backend_scsi.c | 4 +-
> src/storage/storage_backend_sheepdog.c | 4 +-
> src/storage/storage_backend_zfs.c | 6 +-
> src/storage/storage_driver.c | 142 +++++++++-------------
> src/storage/storage_util.c | 8 +-
> src/test/test_driver.c | 54 ++++-----
> tests/storagevolxml2argvtest.c | 20 ++--
> 15 files changed, 465 insertions(+), 197 deletions(-)
>
ACK series, but please see my comments before pushing.
Michal
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
