On Tue, Jul 21, 2009 at 01:12:01PM +0200, Miloslav Trma?? wrote: > The XML allows <encryption format='unencrypted'/>, this implementation > canonicalizes the internal representation so that "disk->encryption" is > non-NULL iff encryption information is available. > > Note that partial encryption information (e.g. specifying an encryption > format, but not the key/passphrase) is valid: > * virDomainGetXMLDesc() will only reveal the key/passphrase if > VIR_DOMAIN_XML_SECURE is used. > * A domain with partial encryption information can be defined, > completenes of the information is not verified. The domain won't > start until the remaining information is added, of course. > --- > src/domain_conf.c | 25 +++++++++++++++++++++++-- > src/domain_conf.h | 2 ++ > 2 files changed, 25 insertions(+), 2 deletions(-) This looks fine as a way to integrate. BTW, the XML schemas should be updated under docs/schemas/domain.rng and docs/schemas/storagevol.rng Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list