Perform some cleanups with the auth and encryption processing. This is a precursor to some other changes that will move/create disk <source> level <auth> and <encryption> elements since they are already in the _virStorageSource. I'm still working on the latter, but before there's too many patches. John Ferlan (6): docs: Remove unnecessary <auth> example for iscsi disk type='volume' conf: Add invalid secrettype checks conf: Move <disk> authdef validation conf: Add invalid domain disk encryption test conf: Move <disk> encryption validation conf: Use virXMLFormatElement to format disk source network docs/formatdomain.html.in | 6 - src/conf/domain_conf.c | 126 ++++++++++----------- ...drive-network-iscsi-auth-secrettype-invalid.xml | 33 ++++++ ...k-drive-network-iscsi-auth-wrong-secrettype.xml | 33 ++++++ .../qemuxml2argv-disk-source-pool-mode.args | 3 + .../qemuxml2argv-disk-source-pool-mode.xml | 13 +++ .../qemuxml2argv-luks-disk-invalid.xml | 37 ++++++ tests/qemuxml2argvtest.c | 3 + .../qemuxml2xmlout-disk-source-pool-mode.xml | 13 +++ 9 files changed, 198 insertions(+), 69 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth-secrettype-invalid.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth-wrong-secrettype.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-luks-disk-invalid.xml -- 2.13.5 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list