Re: [PATCH] news: document spice rendernode DAC changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2017-09-12 at 12:37 -0400, Cole Robinson wrote:
> Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx>
> ---
>  docs/news.xml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 483f9d6d1..17f00a25e 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -37,6 +37,17 @@
>      <section title="New features">
>      </section>
>      <section title="Improvements">
> +      <change>
> +        <summary>
> +          qemu: DAC permissions properly set for spice renderndoe

I would shuffle the words around a bit:

  qemu: Set DAC permissions properly for SPICE rendernodes

Also note the 'renderndoe' typo.

> +        </summary>
> +        <description>
> +          When a rendernode= path is set for spice GL on qemu:///system,
> +          we now correctly set DAC permissions on the device at VM startup.
> +          This is the last remaining hurdle to let spice GL work for
> +          qemu:///system without any external host changes.

s/spice/SPICE/g

I also suggest wrapping 'rendernode' and qemu:///system in <code>
elements to make them look better in the HTML version.

With those addressed,

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux