On Tue, Sep 05, 2017 at 15:09:34 -0400, John Ferlan wrote:
> Add the capability to use the blockdev-add query-qmp-schema option
> to find the 'password-secret' parameter that will allow the iSCSI
> code to use the master secret object (a/k/a AES) to encrypt the
> secret in an object and only need to provide the object id of
> tha secret on the command line thus obsfuscating the passphrase.
>
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
> src/qemu/qemu_capabilities.c | 4 ++++
> src/qemu/qemu_capabilities.h | 3 +++
> tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml | 1 +
> tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 +
> tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 +
> 5 files changed, 10 insertions(+)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index e7ea6f4..86f27ee 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -439,6 +439,9 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
> "virtio-net.tx_queue_size",
> "chardev-reconnect",
> "virtio-gpu.max_outputs",
> +
> + /* 270 */
> + "iscsi.password-secret",
...
> diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> index f32687d..665a772 100644
> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -426,6 +426,9 @@ typedef enum {
> QEMU_CAPS_CHARDEV_RECONNECT, /* -chardev reconnect */
> QEMU_CAPS_VIRTIO_GPU_MAX_OUTPUTS, /* -device virtio-(vga|gpu-*),max-outputs= */
>
> + /* 265 */
... this is wrong.
> + QEMU_CAPS_ISCSI_PASSWORD_SECRET, /* -drive file.driver=iscsi,...,password-secret= */
> +
> QEMU_CAPS_LAST /* this must always be the last item */
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
