On Thu, Sep 07, 2017 at 11:29:15AM +0200, Andrea Bolognani wrote: > On Wed, 2017-09-06 at 14:25 +0100, Daniel P. Berrange wrote: > > On Wed, Sep 06, 2017 at 03:13:30PM +0200, Andrea Bolognani wrote: > > > msgmerge(1) and friends are required to build libvirt, so the > > > corresponding package should be installed in the Travis worker. > > > > It is only used if you regenerate .po files. 99% of the time > > developers or apps bulding libvirt won't do that, avoiding any > > need for msgmerge. 'make dist' triggers msgmerge, but we don't > > run that in travis - only make & make check > > Is that so? I tried running > > git clean -xdf && ./autogen.sh && make > > on a Debian guest where the gettext package is not installed, > and sure enough the build failed. > > IIUC *.po files are compiled to *.gmo using msgfmt(1), which is > part of the gettext package, and we need to build those along > with the rest because they are (correctly) not tracked in git. > > If you compare [471.1], the last where the build succeeded, and > [472.1], the first where it failed, you can see that even though > they share the same configuration the gettext tools are found by > configure in the former but not in the latter. > > It looks like Travis updated their 'precise' worker in between > those two builds - it jumped from 2.5.0 to 2.9.3: maybe the new > worker is more minimal and doesn't include the gettext package? > > That would explain why we suddenly need to be explicit about it > instead of getting it for free. Yeah, looks like you are right. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
