On Fri, Sep 01, 2017 at 10:39:10AM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1487322 > > In ace45e67abbd I've tried to fix a problem that we get the reply s/I've/I --> the point in the past is known ;) > to a D-Bus call while we were sleeping. In that case the callback > was never set. So I've changed the code that the callback is s/I've/I --> again, we know exactly when :) > called directly in this case. However, I hadn't realized that > since callback is called out of order it lock the virNetDaemon. s/since callback/since the callback s/lock/locks s/virNetDaemon/virNetDaemon object also I'm not sure about 'hadn't realized' being used in this specific case, but I'd rather not object to that. > Exactly the very same virNetDaemon that we are dealing with right > now and have it locked already (in s/have/having or 'that we have already locked' (preferred) > virNetDaemonAddShutdownInhibition()) > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> ACK Erik -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
