Re: [PATCH 4/4] conf: validate IOMMU interrupt remapping setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 08/29/2017 12:48 PM, Ján Tomko wrote:
> This option requires:
>   <ioapic driver='qemu'/>

Just an extra empty line here would make it easier to read...

> Report an error in case someone tries to combine
> it with different ioapic setting.
> 
> Setting 'eim' on without enabling 'intremap' does not make sense.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1457610
> ---
>  src/conf/domain_conf.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux