Re: [PATCH 1/4] conf: use virXMLFormatElement for <iommu><driver>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 08/29/2017 12:48 PM, Ján Tomko wrote:
> Use the new helper to simplify the code.
> This also fixes the bug of not formatting 'eim' in the useless
> case if it's the only enabled attribute.
> ---
>  src/conf/domain_conf.c | 55 ++++++++++++++++++++++++++++----------------------
>  1 file changed, 31 insertions(+), 24 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

If I didn't read patch4, I might have said in a here that perhaps
tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-eim.xml should be
modified to remove "intremap='on' " - good thing I read ahead!  ;-)

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux