On 08/31/2017 08:31 AM, Peter Krempa wrote: > On Thu, Aug 31, 2017 at 09:56:46 +0200, Peter Krempa wrote: >> On Wed, Aug 30, 2017 at 18:46:01 -0400, John Ferlan wrote: > > [...] > >>> scrubbed the file slightly to set qemuctime, selfctime, and >>> selfvers to 0 and change the package to add a "-dirty". > > [...] > >>> +{ >>> + "QMP": { >>> + "version": { >>> + "qemu": { >>> + "micro": 94, >>> + "minor": 9, >>> + "major": 2 >>> + }, >>> + "package": " (v2.10.0-rc4-dirty)" >> >> What changes do you have on top of rc4? >> > > I've actually noticed that you've added the '-dirty' part manually? Why? > That does not make any sense. '-dirty' is added if you have uncommited > changes in the qemu repo, which actually should not be used as a source > of capabilities in libvirt. > I think I was matching what .replies had - I forget the exact details... Still, I don't update that often, but I see that from my qemu.git tree: git status shows: modified: dtc (new commits) So, git submodule update --init --recursive handles that, but now I've got: modified: roms/seabios (untracked content) modified: roms/vgabios (untracked content) Oy vei - so a more forceful approach git reset HEAD^ --hard cleans things up. I got miraculously lucky to pull down rc4 though, because now it's "v2.10.0-47-g1415e8e".... I won't push something with dirty... I'll clean it up first! Tks John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list