On 08/29/2017 02:39 AM, Ashish Mittal wrote: > QEMU changes for VxHS (including TLS support) are already upstream. > This series of patches adds support for VxHS block devices in libvirt. > > Patch 1 adds the base functionality for supporting VxHS protocol. > Patches 2 and 3 add test cases for the base functionality. > > Patch 4 adds two new configuration options in qemu.conf to enable TLS > for VxHS devices. > > Patch 5 implements the main TLS functionality. > Patches 6 through 9 add test cases for the TLS functionality. > > This series has the following changes - > (1) Rebased to latest master. > (2) Most of the review comments for patch 1 have been incorporated. > (3) Patches have been broken into smaller chunks > > TODO: > Changes in response to review comments on the TLS functionality are still > pending and will be addressed next. > So as promised an updated series was sent. I only sent to libvir-list and CC'd Ashish at his work email. The patches are on the archive at: https://www.redhat.com/archives/libvir-list/2017-August/msg00993.html for anyone that doesn't subscribe to libvir-list that would like to look at the changes. John > Ashish Mittal (9): > Add support for Veritas HyperScale (VxHS) block device protocol > Add a test case to verify generation of qemu command line args for a > VxHS disk > Add a test case to verify parsing of VxHS backing storage. > conf: Introduce TLS options for VxHS block device clients > Add TLS support for Veritas HyperScale (VxHS) block device protocol > Add a test case to verify TLS arguments are added for VxHS disk > Add a test case to verify TLS arguments are parsed correctly for a > VxHS disk > Add a test case to verify setting vxhs_tls=0 disables TLS for VxHS > disks > Add a test case to verify different TLS combinations for a VxHS disk > > docs/formatdomain.html.in | 31 ++++++++- > docs/schemas/domaincommon.rng | 18 +++++ > src/conf/domain_conf.c | 19 ++++++ > src/libxl/libxl_conf.c | 1 + > src/qemu/libvirtd_qemu.aug | 4 ++ > src/qemu/qemu.conf | 23 +++++++ > src/qemu/qemu_block.c | 78 ++++++++++++++++++++++ > src/qemu/qemu_command.c | 76 +++++++++++++++++++++ > src/qemu/qemu_conf.c | 7 ++ > src/qemu/qemu_conf.h | 3 + > src/qemu/qemu_driver.c | 3 + > src/qemu/qemu_parse_command.c | 15 +++++ > src/qemu/test_libvirtd_qemu.aug.in | 2 + > src/util/virstoragefile.c | 53 ++++++++++++++- > src/util/virstoragefile.h | 10 +++ > src/xenconfig/xen_xl.c | 1 + > ...ml2argv-disk-drive-network-tlsx509-err-vxhs.xml | 34 ++++++++++ > ...-disk-drive-network-tlsx509-multidisk-vxhs.args | 43 ++++++++++++ > ...v-disk-drive-network-tlsx509-multidisk-vxhs.xml | 56 ++++++++++++++++ > ...muxml2argv-disk-drive-network-tlsx509-vxhs.args | 30 +++++++++ > ...emuxml2argv-disk-drive-network-tlsx509-vxhs.xml | 34 ++++++++++ > .../qemuxml2argv-disk-drive-network-vxhs.args | 27 ++++++++ > .../qemuxml2argv-disk-drive-network-vxhs.xml | 34 ++++++++++ > tests/qemuxml2argvtest.c | 10 +++ > tests/virstoragetest.c | 21 ++++++ > 25 files changed, 629 insertions(+), 4 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-err-vxhs.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-multidisk-vxhs.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-multidisk-vxhs.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-vxhs.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-vxhs.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.xml > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list