On Wed, Aug 30, 2017 at 03:14:40PM -0400, Cole Robinson wrote: > On 08/28/2017 03:56 AM, Pavel Hrdina wrote: > > On Sun, Aug 27, 2017 at 11:04:38AM -0400, Cole Robinson wrote: > >> Rather than require an explicit blacklist that needs to be extended > >> for every new VIDEO_TYPE > >> > >> Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx> > >> --- > >> src/qemu/qemu_domain.c | 13 +++++-------- > >> 1 file changed, 5 insertions(+), 8 deletions(-) > > > > NACK, we prefer to listing all possible values for typed switch. It > > forces a contributor to look at all places where that switch is used > > in order to consider whether that place should be updated or not. > > > > This patch isn't necessary anyways, I can drop it and squash this into patch > #2, ACK to that? (if so I'll push after the release) ACK to that, I was about to suggest it :). Pavel
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
