On Thu, Aug 24, 2017 at 09:56:48 +0300, Nikolay Shirokovskiy wrote:
> Looks like it is more simple to drop this optimization as we are
> going to add getting disks stats during migration via quering qemu
> process and checking if we have to acquire job condition becomes
> more complicate.
...
> @@ -12947,7 +12942,8 @@ qemuDomainGetJobStatsInternal(virQEMUDriverPtr driver,
> if (jobInfo->status == QEMU_DOMAIN_JOB_STATUS_ACTIVE ||
> jobInfo->status == QEMU_DOMAIN_JOB_STATUS_MIGRATING ||
> jobInfo->status == QEMU_DOMAIN_JOB_STATUS_POSTCOPY) {
> - if (fetch &&
> +
Remove the empty line here
> + if (events && jobInfo->status != QEMU_DOMAIN_JOB_STATUS_ACTIVE &&
and break this line after the first "&&".
> qemuMigrationFetchMigrationStats(driver, vm, QEMU_ASYNC_JOB_NONE,
> &jobInfo->stats, false) < 0)
> goto cleanup;
ACK with the trivial change.
Jirka
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
