On Thu, Aug 24, 2017 at 09:56:40 +0300, Nikolay Shirokovskiy wrote: > Current code consults job.current->stats.status to check for postcopy > state. First it is more correct to check for both job.current->status > and job.current->stats.status.code because on some paths on failures > we change only the former. Second if qemu supports migration events > then stats can change unexpectedly. I'm not sure I understand what you're trying to say. Could you explain this a bit more? > Let's introduce QEMU_DOMAIN_JOB_STATUS_POSTCOPY state for job.current->status. > > This patch removes all state checking usage of stats except for > qemuDomainGetJobStatsInternal. This place will be handled separately. > --- > src/qemu/qemu_domain.c | 1 + > src/qemu/qemu_domain.h | 1 + > src/qemu/qemu_driver.c | 5 +++-- > src/qemu/qemu_migration.c | 18 +++++++++++------- > src/qemu/qemu_process.c | 4 ++-- > 5 files changed, 18 insertions(+), 11 deletions(-) ACK Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
