[PATCH v2 03/12] storage: Fill in storage pool @active properly

[John Ferlan <jferlan@xxxxxxxxxx>]

It's a bool not an int, so use true/false and not 1/0

Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
---
 src/conf/virstorageobj.c | 4 ++--
 src/test/test_driver.c   | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c
index eb7664c..a9fa190 100644
--- a/src/conf/virstorageobj.c
+++ b/src/conf/virstorageobj.c
@@ -52,7 +52,7 @@ virStoragePoolObjNew(void)
         return NULL;
     }
     virStoragePoolObjLock(obj);
-    obj->active = 0;
+    obj->active = false;
     return obj;
 }
 
@@ -544,7 +544,7 @@ virStoragePoolObjLoadState(virStoragePoolObjListPtr pools,
      * as active
      */
 
-    obj->active = 1;
+    obj->active = true;
 
  cleanup:
     VIR_FREE(stateFile);
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index aa38f54..989c3a8 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -1130,7 +1130,7 @@ testParseStorage(testDriverPtr privconn,
             virStoragePoolObjUnlock(obj);
             goto error;
         }
-        obj->active = 1;
+        obj->active = true;
 
         /* Find storage volumes */
         if (testOpenVolumesForPool(file, ctxt, obj, i+1) < 0) {
@@ -4322,7 +4322,7 @@ testStoragePoolCreate(virStoragePoolPtr pool,
     if (!(obj = testStoragePoolObjFindInactiveByName(privconn, pool->name)))
         return -1;
 
-    obj->active = 1;
+    obj->active = true;
 
     event = virStoragePoolEventLifecycleNew(pool->name, pool->uuid,
                                             VIR_STORAGE_POOL_EVENT_STARTED,
@@ -4470,7 +4470,7 @@ testStoragePoolCreateXML(virConnectPtr conn,
      * code will not Remove the pool */
     VIR_FREE(obj->configFile);
 
-    obj->active = 1;
+    obj->active = true;
 
     event = virStoragePoolEventLifecycleNew(obj->def->name, obj->def->uuid,
                                             VIR_STORAGE_POOL_EVENT_STARTED,
@@ -4618,7 +4618,7 @@ testStoragePoolDestroy(virStoragePoolPtr pool)
     if (!(obj = testStoragePoolObjFindActiveByName(privconn, pool->name)))
         return -1;
 
-    obj->active = 0;
+    obj->active = false;
 
     if (obj->def->source.adapter.type ==
         VIR_STORAGE_ADAPTER_TYPE_FC_HOST) {
-- 
2.9.5

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list