v4: https://www.redhat.com/archives/libvir-list/2017-August/msg00537.html Changes since v4... I've removed the virObjectLookupKeys completely relying on LookupHash completely. The adjusted LookupHash object uses named "objsUUID" and "objsName" as well as API's to specifically Search or ForEach by Name or UUID. The New, Add, and Remove API's were adjusted in order to handle creating things properly. Even if that adjustment isn't considered what's desired, at least look at patches 1, 10, and 14 separately. John Ferlan (15): util: Use VIR_ERROR instead of VIR_WARN util: Introduce virObjectLookupHash util: Introduce virObjectLookupHash{Add|Remove} util: Introduce virObjectLookupHashFind[Locked] util: Introduce virObjectLookupHashForEach{UUID|Name} util: Introduce virObjectLookupHashSearch{UUID|Name}[Locked] nodedev: Use virObjectLookupHash secret: Use virObjectLookupHash util: Introduce virObjectLookupHashClone Revert "interface: Consume @def in virInterfaceObjNew" interface: Use virObjectLookupHash test: Clean up test driver Interface interactions util: Introduce virObjectLookupHashPrune network: Fix virNetworkObjBridgeInUse return type network: Use virObjectLookupHash src/conf/virinterfaceobj.c | 289 ++++++++++--------- src/conf/virnetworkobj.c | 280 ++++++------------ src/conf/virnetworkobj.h | 2 +- src/conf/virnodedeviceobj.c | 273 +++++------------- src/conf/virsecretobj.c | 251 +++++----------- src/libvirt_private.syms | 14 + src/test/test_driver.c | 55 +--- src/util/virobject.c | 675 +++++++++++++++++++++++++++++++++++++++++++- src/util/virobject.h | 123 ++++++++ 9 files changed, 1189 insertions(+), 773 deletions(-) -- 2.9.5 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list