On Wed, Jul 22, 2009 at 12:23:31PM +0100, Daniel P. Berrange wrote: > On Wed, Jul 22, 2009 at 01:20:58AM -0400, Laine Stump wrote: > > Since virRaiseErrorFull needs to lock the conn, we must take care to > > call it with the lock *not* held. > > > > If this patch is approved, similar patches need to be done for other > > types in datatypes.c > > Doh, that's a annoying edge case ! ACK I wonder why we didn't see deadlocks so far ... > If you have time to do the same change to other methods in this > file that'd be very helpful I pushed the patch for the Interface, Laine do you think you will fix the others or should I do it ? thanks, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list