Re: [libvirt-php][PATCH] Generate AUTHORS file

[Ján Tomko <jtomko@xxxxxxxxxx>]

On Tue, Aug 15, 2017 at 07:43:36AM +0200, Michal Privoznik wrote:
> On 08/14/2017 05:42 PM, Ján Tomko wrote:
> > On Sat, Aug 05, 2017 at 02:29:58PM +0200, Michal Privoznik wrote:
> > > +gen-AUTHORS:
> > > +    $(AM_V_GEN)if test -d $(srcdir)/.git; then \
> > > +        out="`cd $(srcdir) && git log --pretty=format:'%aN <%aE>' |
> > > sort -u | sed 's/^/\t/'`" && \
> > > +        perl -p -e "s/#authorslist#// and print '$$out'" \
> > > +          < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \
> > > +        mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS ; \
> > > +    fi
> >
> > What is the point of going through a temporary file and spawning one
> > extra process on success? We use the pattern a lot in libvirt's Makefile
> > and it just seems wasteful to me.
>
> What extra process do you have in mind?

mv

> > Also, this probably won't work correctly with git work-trees, since
> > those have .git as a regular file, not a directory. See:
> > http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=e97dce1b84ab63
>
> Well, in that case it's broken in libvirt too. Feel free to fix it and
> I'll cherry-pick the fix into -php then.

I volunteer to cherry-pick it to libvirt, just in case you fix it in
libvirt-php first.

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list