On Tue, Jul 21, 2009 at 03:03:53PM +0100, Daniel P. Berrange wrote:
> On Tue, Jul 21, 2009 at 01:39:51PM +0200, Thomas Treutner wrote:
> > On Tuesday 21 July 2009 13:01:06 Daniel P. Berrange wrote:
> > > On Tue, Jul 21, 2009 at 11:52:11AM +0200, Thomas Treutner wrote:
> > > > Hi,
> > > >
> > > > I'm playing around with libvirt-0.6.5 and libvirt-java-0.2.1 these days.
You mean libvirt-java-0.1.1, I don't think I ever released a newer
version. Unfortunately as you found out the bindings are in a not so
nice shape. The good point is that someone with more Java knowledge than
me is looking at cleaning this up !
> I've just looked at the java code and found this horrible snippet
>
> JNIEXPORT jint JNICALL Java_org_libvirt_Connect__1setDom0Memory
> (JNIEnv *env, jobject obj, jlong memory){
> return virDomainSetMemory(NULL, memory);
> }
>
>
>
> This could not possibly have ever worked. It is forbidden to pass
> NULL to virDomainSetMemory(), no matter what hypervisor driver.
>
> We should just remove the setDom0Memory() method from the java
> code, since it is fundamentally broken & always has been
I never realized we had this in, yup I need to clean this up !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list