Re: [PATCH 1/8] Remove superfluous usage of virDomainDeviceInfoNeedsFormat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 07/26/2017 09:29 AM, Ján Tomko wrote:
> This function returns false if virDomainDeviceInfoFormat
> would not format anything.
> 
> Using it as the sole condition to decide whether to call
> virDomainDeviceInfoFormat or not is pointless, since
> the conditions are repeated in virDomainDeviceInfoFormat.
> ---
>  src/conf/domain_conf.c | 33 +++++++++++----------------------
>  1 file changed, 11 insertions(+), 22 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

FWIW:

minor nit... In virDomainDeviceInfoFormat, there's an "info->rombar ||"
condition that could be "info->rombar != VIR_TRISTATE_SWITCH_ABSENT ||"

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux