Re: [PATCH 1/5] nodedev: mdev: Report an error when virFileResolveLink fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 07/26/2017 02:44 AM, Erik Skultety wrote:
> It might happen that virFileResolveLinkHelper fails on the lstat system
> call. virFileResolveLink expects the caller to report an error when it
> fails, however this wasn't the case for udevProcessMediatedDevice.
> 
> Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
> ---
>  src/node_device/node_device_udev.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Could have gone with "resolve mdev path" or "resolve mediated device
path"...  Just makes it clear what failed.


Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux