This is V2 of a long standing series to add unit tests for libvirt domXML to libxl_domain_config conversions. There's a lot more history than a V2 would imply, which can be read in the last posting of the series https://www.redhat.com/archives/libvir-list/2017-February/msg01477.html Unlike attempts of the past, I actually feel good about this version and I hope others feel the same so we can finally get the series pushed! Patch1 changes the checks for <emulator> in the libxl driver to make them mockable. Patch2 provides mocking of the emulator checks and some libxl functions, and of course provides the tests. Jim Fehlig (2): libxl: make emulator checks mockable libxl: Add a test suite for libxl_domain_config generator m4/virt-driver-libxl.m4 | 4 + src/libxl/libxl_capabilities.c | 30 +++- src/libxl/libxl_capabilities.h | 5 +- src/libxl/libxl_conf.c | 17 +- src/libxl/libxl_domain.c | 2 +- tests/Makefile.am | 18 ++- tests/libxlxml2domconfigdata/basic-hvm.json | 89 +++++++++++ tests/libxlxml2domconfigdata/basic-hvm.xml | 36 +++++ tests/libxlxml2domconfigdata/basic-pv.json | 65 ++++++++ tests/libxlxml2domconfigdata/basic-pv.xml | 28 ++++ tests/libxlxml2domconfigdata/moredevs-hvm.json | 111 +++++++++++++ tests/libxlxml2domconfigdata/moredevs-hvm.xml | 63 ++++++++ tests/libxlxml2domconfigtest.c | 209 +++++++++++++++++++++++++ tests/virmocklibxl.c | 106 +++++++++++++ 14 files changed, 764 insertions(+), 19 deletions(-) create mode 100644 tests/libxlxml2domconfigdata/basic-hvm.json create mode 100644 tests/libxlxml2domconfigdata/basic-hvm.xml create mode 100644 tests/libxlxml2domconfigdata/basic-pv.json create mode 100644 tests/libxlxml2domconfigdata/basic-pv.xml create mode 100644 tests/libxlxml2domconfigdata/moredevs-hvm.json create mode 100644 tests/libxlxml2domconfigdata/moredevs-hvm.xml create mode 100644 tests/libxlxml2domconfigtest.c create mode 100644 tests/virmocklibxl.c -- 2.13.1 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
