On 07/28/2017 12:59 PM, Pavel Hrdina wrote: > On Fri, Jul 28, 2017 at 12:38:56PM -0400, John Ferlan wrote: >> Instead of making virObjectLock be the entry point for two >> different types of locks, let's create a virObjectLockWrite API >> which will be able to return status and force the (new) consumers >> of the RWLock to make sure the lock is really obtained when the >> "right" object type is passed. > > If you remove the return value for the same reason as in the first patch > > Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > Fine again, minority opinion it seems. Still rename from virObjectLockWrite to virObjectRWLockWrite is expect, right (or is that Write) John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
