On Tue, Jul 21, 2009 at 02:09:38AM -0400, Laine Stump wrote: > > These patches correspond to patches 2-6 in the set I sent yesterday > (the 1st and 2nd had no changes, so they stand as-is). They > incorporate all changes brought up in review of the first set. In > particular: > > 1) When looking for a cached virInterface object for an interface, I > now check that the mac address being searched for matches the one in > the virInterface (case insensitive comparison). If it doesn't match, I > create a new object rather than trying to modify the existing object > with the same interface name, as that could have led to "improper > behavior". > > 2) in virInterfaceFindByMACString() I now follow danpb's suggestion > and use continue, rather than getting fancy with booleans. > > 3) testinterfaceCreate() and testInterfaceDestroy() now check if the > interface has already been created/destroyed, and won't do the same > operation twice in a row. > > 4) in the netcf backend driver, I now "roundtrip" the xml data in both > interfaceDefineXML() and interfaceGetXMLDesc(). ACK this series looks good now Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list