[PATCH 0/4] Clean up machineName-related code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Just in case we'll want to use the "cleaned-up" machineName for
anything else in the future, I decided to modify the code so that it
is always generated, saved and cleaned-up.  While doing that I
identified some code duplication, leak and a TODO/XXX comment that are
all fixed with this series.  And it only adds four lines overall!

Martin Kletzander (4):
  conf: Pass config.priv to xmlopt->privateData.alloc
  qemu: Save qemu driver in qemuDomainObjPrivateData
  lxc: Make lxcProcessStop callable even without PID being available
  Move machineName generation from virsystemd into domain_conf

 src/bhyve/bhyve_domain.c   |  2 +-
 src/conf/domain_conf.c     | 65 +++++++++++++++++++++++++++++++++++++++++++++-
 src/conf/domain_conf.h     |  7 ++++-
 src/libvirt_private.syms   |  2 +-
 src/libxl/libxl_domain.c   |  2 +-
 src/lxc/lxc_cgroup.c       |  5 +---
 src/lxc/lxc_domain.c       | 21 ++++++++++++++-
 src/lxc/lxc_domain.h       |  3 +++
 src/lxc/lxc_process.c      | 57 +++++++++++-----------------------------
 src/qemu/qemu_cgroup.c     | 24 ++++-------------
 src/qemu/qemu_domain.c     | 24 ++++++++++++++++-
 src/qemu/qemu_domain.h     |  5 ++++
 src/qemu/qemu_driver.c     |  2 +-
 src/qemu/qemu_process.c    | 11 +++++---
 src/uml/uml_driver.c       |  2 +-
 src/util/vircgroup.c       | 15 ++++-------
 src/util/vircgroup.h       | 14 +++++-----
 src/util/virsystemd.c      | 62 -------------------------------------------
 src/util/virsystemd.h      |  5 ----
 src/vmware/vmware_driver.c |  2 +-
 src/vz/vz_utils.c          |  2 +-
 tests/virsystemdtest.c     |  4 +--
 22 files changed, 170 insertions(+), 166 deletions(-)

--
2.13.3

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux