On 07/20/2017 11:11 PM, Julio Faracco wrote: > This commit adds the unix socket URL support to 'domdisplay' command. > Before, even if an user was using unix socket to define a spice graphics, > the command 'domdisplay' showed that the settings were not supported. Now, > the command shows the proper URL: spice+unix://foo/bar.sock. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1336720 > > Signed-off-by: Julio Faracco <jcfaracco@xxxxxxxxx> > --- > tools/virsh-domain.c | 49 ++++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 38 insertions(+), 11 deletions(-) Hey, this looks roughly okay. But, the changes you made cause a small problem: ./tools/virsh domdisplay --all fedora vnc://localhost:0 spice+unix:///tmp/spice.sock rdp+unix://(null) And I don't have any RDP configured for my domain. I only have vnc and spice. Can you please look into that and send v2? Thanks. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
