On 07/21/2017 12:44 PM, Andrea Bolognani wrote: > Instead of going through two completely different code paths, > one of which repeats the same hardcoded bit of information > three times in rapid succession, depending on whether or not > a firmware list has been provided at configure time, just > provide a reasonable default value and remove the extra code. > > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > --- > src/qemu/qemu_conf.c | 31 +++++++------------------------ > 1 file changed, 7 insertions(+), 24 deletions(-) ACK. I wonder who introduced the code in the first place O:-) Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list