Re: [PATCH 2/5] qemu: domain: Extract parsing and formatting of priv->autoNodeset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2017-07-12 at 15:44 +0200, Peter Krempa wrote:
>  static int
> +qemuDomainObjPrivateXMLParseAutomaticPlacement(virQEMUDriverPtr driver,
> +                                               qemuDomainObjPrivatePtr priv,
> +                                               xmlXPathContextPtr ctxt)

I think you should invert the first and last arguments to
keep the signature closer to that of the calling function.


Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux