Re: [PATCH 2/5] qemu: blockcopy: Explicitly assert 'reuse' for block devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 07/11/2017 11:46 AM, Peter Krempa wrote:
> When copying to a block device, the block device will already exist. To
> allow users using a block device without any preparation, they need to
> use the block copy without VIR_DOMAIN_BLOCK_COPY_REUSE_EXT.
> 
> This means that if the target is an existing block device we don't need
> to prepare it, but we can't reject it as being existing.
> 
> To avoid breaking this feature, explicitly assume that existing block
> devices will be reused even without that flag explicitly specified,
> while skipping attempts to create it.
> 
> qemuMonitorDriveMirror still needs to honor the flag as specified by the
> user, since qemu overwrites the metadata otherwise.
> ---
>  src/qemu/qemu_driver.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux