When we start a vm, we call JOB_MASK(QEMU_JOB_NONE) at follow backtrace Breakpoint 1, qemuDomainObjPrivateXMLFormat (buf=0x7f8078fcd510, vm=0x7f808c2c7d70) at qemu/qemu_domain.c:1779 1779 if (!qemuDomainTrackJob(job)) (gdb) p job $1 = QEMU_JOB_NONE (gdb) bt #0 qemuDomainObjPrivateXMLFormat (buf=0x7f8078fcd510, vm=0x7f808c2c7d70) at qemu/qemu_domain.c:1779 #1 0x00007f80899e7988 in virDomainObjFormat (xmlopt=0x7f808c275c60, obj=obj@entry=0x7f808c2c7d70, caps=0x7f808c25b450, flags=flags@entry=625) at conf/domain_conf.c:24936 #2 0x00007f80899e7a5c in virDomainSaveStatus (xmlopt=<optimized out>, statusDir=0x7f808c28de30 "/var/run/libvirt/qemu", obj=obj@entry=0x7f808c2c7d70, caps=<optimized out>) at conf/domain_conf.c:25149 #3 0x00007f806f7d8840 in qemuProcessLaunch (conn=conn@entry=0x7f805c0047c0, driver=driver@entry=0x7f808c2d1530, vm=vm@entry=0x7f808c2c7d70, asyncJob=asyncJob@entry=QEMU_ASYNC_JOB_START, incoming=incoming@entry=0x0, snapshot=snapshot@entry=0x0, vmop=vmop@entry=VIR_NETDEV_VPORT_PROFILE_OP_CREATE, flags=flags@entry=17) at qemu/qemu_process.c:5757 this is not a problem, just looks very awkward. -----邮件原件----- 发件人: Jiri Denemark [mailto:jdenemar@xxxxxxxxxx] 发送时间: 2017年7月17日 21:31 收件人: Caoxinhua 抄送: libvir-list@xxxxxxxxxx; jferlan@xxxxxxxxxx; Yanqiangjun; Huangweidong (C); weifuqiang 主题: Re: [PATCH] fix 1 << -1 at JOB_MASK macro On Sat, Jul 15, 2017 at 14:42:39 +0800, xinhua.Cao wrote: > From: caoxinhua <caoxinhua@xxxxxxxxxx> > > when we start a vm, we call JOB_MASK(QEMU_JOB_NONE), then 1 << -1 will > be execute. we fix it as return 0 Could you point us to the place in our code where JOB_MASK is called on QEMU_JOB_NONE? Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list